He was born in 1940 in Allahabad, British India. He settled in Karachi after the 1947 independence of Pakistan but later on moved to Lahore, Pakistan due to family disputes. There he lived in a single room flat at the renowned Anarkali Bazaar, Lahore.

Besides writing song-lyrics for Indian and Pakistani movies, he was famous for writing the popular Sabri Brothers Qawwali "Bhar do jholi meri ya Muhammad" originally sung back in 1975.

He also wrote "Iss Shane Karam Ka" Nusrat Fateh Ali Khan's qawwali. He then wrote the famous qawwali "Tumhain Dil Lagi Bhool Jani Paray Gi" and "Ya Hussain Ya Hussain" qawwalis, both sung by Nusrat Fateh Ali Khan.